Welcome to NeoOffice developer notes and announcements
NeoOffice
Developer notes and announcements
 
 

This website is an archive and is no longer active
NeoOffice announcements have moved to the NeoOffice News website


Support
· Forums
· NeoOffice Support
· NeoWiki


Announcements
· Twitter @NeoOffice


Downloads
· Download NeoOffice


  
NeoOffice :: View topic - Native OS X grammar checking
Native OS X grammar checking
 
   NeoOffice Forum Index -> NeoOffice Testing
View previous topic :: View next topic  
Author Message
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11949

PostPosted: Thu Jul 03, 2014 9:55 am    Post subject: Native OS X grammar checking

I have implemented grammar checking using OS X's native grammar checking service into NeoOffice 2014. With this new feature, any spellchecking operation automatically does grammar checking as well.

You can test our new grammar checking code by installing either of the following test patches. The screen snapshots in this post show how NeoOffice's underlying OpenOffice code displays grammar errors found by our code:

NeoOffice 2014:
http://nick.neooffice.org/test/NeoOffice-2014-Test-1-Intel.dmg

NeoOffice 2014 Free Edition:
http://nick.neooffice.org/test/NeoOffice-2014_Free_Edition-Test-1-Intel.dmg



Patrick
Back to top
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11949

PostPosted: Sun Jul 06, 2014 5:42 pm    Post subject:

While testing the new grammar checking code, I started seeing a deadlock in NeoOffice's underlying OpenOffice code. I found that the OpenOffice code
uses a separate thread to invoke our grammar checker and, as a result of their code's need to coordinate multiple locks in a separate thread, deadlocking can occur when the menubar is clicked or when a new window appears.

I have fixed this deadlocking bug by changing the OpenOffice grammar checker management code. In the following test patches, the grammar checker management code no longer runs on a separate thread. Instead, it now operates like spellchecking: each sentence is queued and processed a few sentences at a time in the OpenOffice event dispatching thread:

NeoOffice 2014:
http://nick.neooffice.org/test/NeoOffice-2014-Test-2-Intel.dmg

NeoOffice 2014 Free Edition:
http://nick.neooffice.org/test/NeoOffice-2014_Free_Edition-Test-2-Intel.dmg

NeoOffice 3.4.1:
http://nick.neooffice.org/test/NeoOffice-3.4.1-Patch-5-Test-1-Intel.dmg

Edit by pluby: added NeoOffice 3.4.1 test patch.

Patrick
Back to top
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11949

PostPosted: Mon Jul 07, 2014 9:23 am    Post subject:

Because the OpenOffice.org grammar checker management code causes hanging, I backported my fix for the OpenOffice bug to NeoOffice 3.4.1.

A link to the test patch is in my previous post. Note that I also included my native OS X grammar checking code in the NeoOffice 3.4.1 test patch.

Patrick
Back to top
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11949

PostPosted: Wed Jul 16, 2014 3:50 pm    Post subject:

FYI. I have included this new feature in NeoOffice 2014.1, NeoOffice 2014.1 Free Edition, and NeoOffice 3.4.1 Patch 6.

Patrick
Back to top
Display posts from previous:   
   NeoOffice Forum Index -> NeoOffice Testing All times are GMT - 7 Hours
Page 1 of 1

 
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Powered by phpBB © 2001, 2005 phpBB Group

All logos and trademarks in this site are property of their respective owner. The comments are property of their posters, all the rest © Planamesa Inc.
NeoOffice is a registered trademark of Planamesa Inc. and may not be used without permission.
PHP-Nuke Copyright © 2005 by Francisco Burzi. This is free software, and you may redistribute it under the GPL. PHP-Nuke comes with absolutely no warranty, for details, see the license.