Welcome to NeoOffice developer notes and announcements
NeoOffice
Developer notes and announcements
 
 

This website is an archive and is no longer active
NeoOffice announcements have moved to the NeoOffice News website


Support
· Forums
· NeoOffice Support
· NeoWiki


Announcements
· Twitter @NeoOffice


Downloads
· Download NeoOffice


  
NeoOffice :: View topic - Fixes for bugs when using the NeoOffice :: Services menu
Fixes for bugs when using the NeoOffice :: Services menu
 
   NeoOffice Forum Index -> NeoOffice Testing
View previous topic :: View next topic  
Author Message
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11949

PostPosted: Tue Dec 30, 2014 10:14 am    Post subject: Fixes for bugs when using the NeoOffice :: Services menu

The new native "speak to text" feature uses NeoOffice's OS X Services code and while working on this new feature, I found and fixed the following bugs that occurred when selecting the NeoOffice :: Services menu:
  • When in a Calc document, the Services menu would use text from the last selected combobox instead of the currently selected cell
  • When in a Writer document, the Services menu would use the last selected text even after unselecting all text
The fixes for these bugs are in the following test patches for anyone who wants to test the fix. I fixed the bug by forcing NeoOffice's underlying OpenOffice code to copy the currently selection to the system clipboard and then passing any text in the system clipboard the various OS X services:

NeoOffice 2014.6:
http://nick.neooffice.org/test/NeoOffice-2014.6-Test-2-Intel.dmg

NeoOffice 2014.6 Free Edition:
http://nick.neooffice.org/test/NeoOffice-2014.6_Free_Edition-Test-2-Intel.dmg

NeoOffice 3.4.1:
http://nick.neooffice.org/test/NeoOffice-3.4.1-Patch-10-Test-2-Intel.dmg

Patrick


Last edited by pluby on Tue Jan 13, 2015 8:00 pm; edited 1 time in total
Back to top
sardisson
Town Crier
Town Crier


Joined: Feb 01, 2004
Posts: 4588

PostPosted: Tue Dec 30, 2014 3:02 pm    Post subject: Re: Fixes for bugs when using the NeoOffice :: Services menu

pluby wrote:
When in a Calc document, the Services menu would use text from the last selected combobox instead of the currently selected cell

FWIW, on 10.8.5, it seems that Neo would use the last selected text regardless of where it was (e.g., selected text in a cell/edit bar during editing) or alternately claim that no Services were available, but regardless, Patch-10-Test-2 seems to fix the behavior so Neo always uses the currently selected cell when there's no other explicitly selected text.

As a side-effect, I notice that whenever you highlight the Services menu, the "this cell has been copied" highlighting happens to the cell (which makes sense, given your description of the changes in the fix.)

pluby wrote:
When in a Writer document, the Services menu would use the last selected text even after unselecting all text

I could not figure out how to trigger this in 10.8.5 (3.4.1 Patch-10 or 2014.6); whenever I selected text, then deselected all text, the Services menu reported there were no Services available.

Quote:
I fixed the bug by forcing NeoOffice's underlying OpenOffice code to copy the currently selection to the system clipboard and then passing any text in the system clipboard the various OS X services


I assume there's no way to force-copy into the Services' pasteboard(s) directly? I ask because generally speaking in Mac OS X (and in NeoOffice prior to these patches), Service requests don't stomp the contents of the general pasteboard ("the clipboard"). Practically speaking, I don't know if it's a big deal--I'm guessing it's not a common workflow to copy something, perform a Service request on something else, and then paste the clipboard somewhere, though I have been known, when working in various apps, to cut something, do a bunch of editing on what's left, and then paste the cut stuff post-editing. So any time there's a NeoOffice Service or Text-to-Speech request in the middle of something like that, there's potential dataloss due to unexpected behavior, because normally only another explicit copy/cut operation replaces the current contents of the clipboard. Like I said, I don't know how common any of these scenarios are, but because they do potentially involve dataloss now, I wanted to mention it.

Smokey

_________________
"[...] whether the duck drinks hot chocolate or coffee is irrelevant." -- ovvldc and sardisson in the NeoWiki
Back to top
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11949

PostPosted: Wed Dec 31, 2014 1:31 pm    Post subject: Re: Fixes for bugs when using the NeoOffice :: Services menu

sardisson wrote:
I assume there's no way to force-copy into the Services' pasteboard(s) directly? I ask because generally speaking in Mac OS X (and in NeoOffice prior to these patches), Service requests don't stomp the contents of the general pasteboard ("the clipboard")....


I think there might be a way to get NeoOffice's underlying OpenOffice code to copy to an internal buffer instead of the general pasteboard. I should know if this is possible in the next few days.

Patrick
Back to top
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11949

PostPosted: Fri Jan 02, 2015 9:55 am    Post subject: Re: Fixes for bugs when using the NeoOffice :: Services menu

I found a way to get NeoOffice's underlying OpenOffice code to copy to an internal buffer instead of the general pasteboard.

In the following test patches, the NeoOffice :: Services menu and OS X's "text to speech" feature should no longer change what is in the general pasteboard:

NeoOffice 2014.5:
http://nick.neooffice.org/test/NeoOffice-2014.6-Test-3-Intel.dmg

NeoOffice 2014.5 Free Edition:
http://nick.neooffice.org/test/NeoOffice-2014.6_Free_Edition-Test-3-Intel.dmg

NeoOffice 3.4.1:
http://nick.neooffice.org/test/NeoOffice-3.4.1-Patch-10-Test-3-Intel.dmg

Patrick
Back to top
sardisson
Town Crier
Town Crier


Joined: Feb 01, 2004
Posts: 4588

PostPosted: Fri Jan 02, 2015 3:05 pm    Post subject:

Yep, seems good on 10.8.5 in both 3.4.1 and 2014.5 with the new Test-3 Smile

Thanks, Patrick (and happy new year to you, in addition)!

Smokey

_________________
"[...] whether the duck drinks hot chocolate or coffee is irrelevant." -- ovvldc and sardisson in the NeoWiki
Back to top
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11949

PostPosted: Sat Jan 31, 2015 10:10 am    Post subject:

FYI. I have included the fix for this bug in NeoOffice 2014.7 which is available in Apple's Mac App Store.

I have also included the fix in NeoOffice 3.4.1 Patch 11 which can be downloaded from the NeoOffice patch download page.

Patrick
Back to top
Display posts from previous:   
   NeoOffice Forum Index -> NeoOffice Testing All times are GMT - 7 Hours
Page 1 of 1

 
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Powered by phpBB © 2001, 2005 phpBB Group

All logos and trademarks in this site are property of their respective owner. The comments are property of their posters, all the rest © Planamesa Inc.
NeoOffice is a registered trademark of Planamesa Inc. and may not be used without permission.
PHP-Nuke Copyright © 2005 by Francisco Burzi. This is free software, and you may redistribute it under the GPL. PHP-Nuke comes with absolutely no warranty, for details, see the license.