Fix for repaint bug when editing a formula in Calc

pluby · The Architect Joined: Jun 16, 2003 Posts: 11949

While editing a spreadsheet yesterday, I found a repaint bug that occurs when I edit a formula using the following steps:

1. Open a spreadsheet and go to a cell in a column to the right of the window width so that some of the left columns scroll out of view. In my case, I seleteced cell Z1.

2. Start entering a formula like "=if(" and then use the arrow key to add a cell to the left of the selected cell into the formula. In my case, I used cell S1.

3. Continue adding to the formula by entering "=0;0;" and then use the arrow to add a cell that is to the left of the visible window width.

At this point, when arrowing shifts a column into view from on the left side of the window, the selected cell's column should shift out of view on the right side of the window. The bug is that the formula text is redrawn in the wrong column as shown in the attached screen snapshot.

The fix for this bug is in the following test patches for anyone who wants to test the fix. I fixed the bug by forcing NeoOffice's underlying OpenOffice code to repaint certain areas of the window immediately after copying of bits from one part of a window into the same window. This copying of window bits is used extensively by OpenOffice when scrolling within a document:

NeoOffice 2014.6:
http://nick.neooffice.org/test/NeoOffice-2014.6-Test-2-Intel.dmg

NeoOffice 2014.6 Free Edition:
http://nick.neooffice.org/test/NeoOffice-2014.6_Free_Edition-Test-2-Intel.dmg

NeoOffice 3.4.1:
http://nick.neooffice.org/test/NeoOffice-3.4.1-Patch-10-Test-2-Intel.dmg

Patrick

pluby · The Architect Joined: Jun 16, 2003 Posts: 11949

FYI. I have included the fix for this bug in NeoOffice 2014.7 which is available in Apple's Mac App Store.

I have also included the fix in NeoOffice 3.4.1 Patch 11 which can be downloaded from the NeoOffice patch download page.

Patrick

pluby · The Architect Joined: Jun 16, 2003 Posts: 11949

While editing a spreadsheet yesterday, I found that this bug still occurs in a few cases so I have modified my fix slightly.

The modified fix for this bug is in the following test patches for anyone who wants to test the fix:

NeoOffice 2014.7:
http://nick.neooffice.org/test/NeoOffice-2014.7-Test-1-Intel.dmg

NeoOffice 2014.7 Free Edition:
http://nick.neooffice.org/test/NeoOffice-2014.7_Free_Edition-Test-1-Intel.dmg

NeoOffice 3.4.1:
http://nick.neooffice.org/test/NeoOffice-3.4.1-Patch-11-Test-1-Intel.dmg

Patrick

pluby · The Architect Joined: Jun 16, 2003 Posts: 11949

While the fix for this bug worked, the fix may reduce scrolling speed in Writer and Calc documents.

After reviewing NeoOffice's underlying OpenOffice code, I found a way to fix this bug without reducing scrolling speed. Instead of forcing NeoOffice to redraw a portion of the document window whenever the bug might occur, the new fix works by preventing Calc from drawing a formula in the wrong location.

The new fix is in the following test patches for anyone who wants to test the fix:

NeoOffice 2014.9:
http://nick.neooffice.org/test/NeoOffice-2014.9-Test-2-Intel.dmg

NeoOffice 2014.9 Free Edition:
http://nick.neooffice.org/test/NeoOffice-2014.9_Free_Edition-Test-2-Intel.dmg

NeoOffice 3.4.1:
http://nick.neooffice.org/test/NeoOffice-3.4.1-Patch-13-Test-2-Intel.dmg

Patrick

pluby · The Architect Joined: Jun 16, 2003 Posts: 11949

FYI. I have included the fix for this bug in NeoOffice 2014.10 which is available in Apple's Mac App Store.

I have also included the fix in NeoOffice 3.4.1 Patch 14 which can be downloaded from the NeoOffice patch download page.

Patrick