Very slow when selecting table in Text Document

[Lorinda]

Today, when working with documents that include a Table, I encountered a major slow-down when selecting a chunk of the document which included a table. Neo was very slow to highlight the selection, it would appear to freeze briefly. First the beginning of the selected area would be highlighted then, after a pause, the bottom part (but not the top) and then the area of focus of the window would shift.

Scrolling also doesn't work properly/lags considerably when the area is selected

I attached a sample document. To reproduce:

-Click next to the word Hymns (just as an example)
-Drag to select to the bottom of the page

I'm using Neo 3.3 Patch 3, test patch 9 on a Mac running OS 10.8.2

Lorinda

[pluby]

I can reproduce the slow-down that you see. I will investigate further to see if I can find the cause of the slowdown.

Patrick

[pluby]

I think that I have fixed this bug in the following test patch. I found that the slowdown was in our native highlighting code. Specifically, our code would try to detect and eliminate any overlapping rectangles in the list of highlighted rectangles to draw. Overlapping rectangles would cause our native highlighting to be cancelled out in such overlapping rectangles.

I have reimplemented code to prevent the "cancelled out" drawing where rectangles overlap that should be much faster than the previous code.

Can you install the following test patch and tell us if the slowdown when highlighting is fixed for you?:

Intel:
http://sally.neooffice.org/test/NeoOffice-3.3-Patch-3-Test-11-Intel.dmg

Patrick

[Lorinda]

That did it! Thanks, Patrick!!

[pluby]

FYI. I have included the fix that was in the previous test patch in NeoOffice 3.3 Patch 4. The patch can be downloaded from the NeoOffice 3.3 patch download page.

Patrick