| View previous topic :: View next topic |
| Author |
Message |
pluby
The Architect
Joined: Jun 16, 2003
Posts: 11949
|
 Posted: Sun Jun 30, 2013 8:48 pm Post subject: Fix for crash when accessing the Mac OS X address book |
|
I found that in Mac OS X 10.8 Mountain Lion, when NeoOffice accesses the Mac OS X address book for the first time, Mac OS X will display a dialog that asks the user if they will grant NeoOffice access to the Mac OS X address book (see first attached screen snapshot).
If the user presses the "Don't allow" button, NeoOffice will crash. I have fixed this bug so that when the user has denied access to the Mac OS X address book, NeoOffice will display a "cannot connect" dialog.
Can anyone install the following test patch and confirm that NeoOffice does not crash when trying to connect to the Mac OS X address book? To try to connect, select the File :: Wizards :: Address Data Source menu and in the dialog that appears, select the "Mac OS X address book" option and press the "Next" button:
Intel:
http://juliette.neooffice.org/test/NeoOffice-3.3-Patch-7-Test-6-Intel.dmg
Note: the Mac OS X dialog that asks the user if they will grant NeoOffice access to the Mac OS X address book will only be displayed once. To grant access to NeoOffice after it has been previously denied, launch the System Preferences application, select the "Security & Privacy" icon, select the "Contacts" item in the "Privacy" tab, and check any "NeoOffice" entries (see second attached screen snapshot).
Patrick |
|
| Back to top |
|
 |
James3359
The Merovingian
Joined: Jul 05, 2005
Posts: 685
Location: North West England
|
| Posted: Mon Jul 01, 2013 9:19 am Post subject: |
|
I can confirm that with the patch NeoOffice behaves as stated ("cannot connect") when "Don't allow" is pressed.
_________________
MacBook Pro
13-inch, Mid 2012
Processor 2.5 GHz Intel Core i5
Memory 4 GB 1600 MHz DDR3
Graphics Intel HD Graphics 4000 512 MB
OS X 10.9.3 (13D65) |
|
| Back to top |
|
|
amayze
The Merovingian
Joined: Oct 24, 2005
Posts: 561
Location: Edinburgh, Scotland
|
| Posted: Tue Jul 02, 2013 8:19 am Post subject: |
|
I've installed Patch 7 Test 6. I must have previously allowed NeoOffice to access my address book as I was not asked, however it did take along time after I clicked Next for the next screen to appear. Long enough, in fact for me to launch Activity Monitor and take a sample (attached). Though this may be a function of having over 1000 contacts in my address book and 10 groups.
This happens when NeoOffice has just been launched and I invoke the Wizard as per your steps. When I click Next the MacOS wait flower shows for a couple of seconds, then disappears, but the window does not update for another 30 seconds or so. During this time the mouse pointer is the Spinning Pizza of Death while it is over the Wizard's window and the window is stuck on top. Even switching to other applications does not hide it.
Subsequent uses of the Wizard do not show this delay until I quit and re-launch NeoOffice.
In addition to this there is a visual bug in the third step "Data Source Title". The bottom of the "Make this address book available..." check box is cut off.
Yours,
Andy |
|
| Back to top |
|
|
pluby
The Architect
Joined: Jun 16, 2003
Posts: 11949
|
| Posted: Tue Jul 02, 2013 8:56 am Post subject: |
|
| amayze wrote: | This happens when NeoOffice has just been launched and I invoke the Wizard as per your steps. When I click Next the MacOS wait flower shows for a couple of seconds, then disappears, but the window does not update for another 30 seconds or so. During this time the mouse pointer is the Spinning Pizza of Death while it is over the Wizard's window and the window is stuck on top. Even switching to other applications does not hide it.
Subsequent uses of the Wizard do not show this delay until I quit and re-launch NeoOffice. |
This is normal if you have a large number of contacts in your Mac OS X address book. NeoOffice's underlying OpenOffice.org code loads your entire address book contact list into memory so the initial load can be slow but subsequent queries will be fast. Note that part of the OpenOffice.org loading process is converting each row and column item from its native address book data format into OpenOffice.org's internal data formats.
You see the spinning cursor because Mac OS X automatically sets that cursor when an application is not fetching system events (in the case because NeoOffice is loading all of your contacts). The dialog window stays on top because it is a modal window and it doesn't get the "application is no longer active" event until after NeoOffice finishes loading all of your contacts.
| amayze wrote: | | In addition to this there is a visual bug in the third step "Data Source Title". The bottom of the "Make this address book available..." check box is cut off. |
This is an old OpenOffice.org bug that occurs in this dialog as well as with a few checkboxes and radio buttons in some other dialogs. The bug is that the OpenOffice.org code sets a clip rectangle before asking the NeoOffice code to draw the checkbox and OpenOffice.org sets the height of the clip rectangle to the height of their old, tiny, non-native checkboxes.
This height is too small for a native checkbox or radio button so NeoOffice's drawing gets clipped. I had tried fixing this a few years ago, but the results looked worse than the clipped drawing so I left the current OpenOffice.org behavior as is since it was the least ugly behavior.
Patrick |
|
| Back to top |
|
|
amayze
The Merovingian
Joined: Oct 24, 2005
Posts: 561
Location: Edinburgh, Scotland
|
| Posted: Tue Jul 02, 2013 8:59 am Post subject: |
|
Thanks for the explanations. Time to trim my address book, perhaps!!
Andy |
|
| Back to top |
|
|
pluby
The Architect
Joined: Jun 16, 2003
Posts: 11949
|
| Posted: Tue Jul 02, 2013 9:10 am Post subject: |
|
| amayze wrote: | | Thanks for the explanations. Time to trim my address book, perhaps!! |
If you rarely use the NeoOffice/OpenOffice/LibreOffice Mac OS X address book feature, I wouldn't worry about trimming it. My impression is that Apple's Contacts and Mail applications access the address book data store natively so they don't need to go through the full load and convert process. As a result, both applications are likely able to handle large contact lists without the dealy that you see in NeoOffice, OpenOffice, or LibreOffice.
Patrick |
|
| Back to top |
|
|
pluby
The Architect
Joined: Jun 16, 2003
Posts: 11949
|
| Posted: Fri Jul 05, 2013 10:47 am Post subject: |
|
| amayze wrote: | | In addition to this there is a visual bug in the third step "Data Source Title". The bottom of the "Make this address book available..." check box is cut off. |
FYI. I think that I have fixed this OpenOffice.org bug while working on some fixes for some pushbutton drawing bugs. Although it seems odd to me, it appears that by telling the OpenOffice.org code that checkboxes are shorter than they really are, the OpenOffice.org code moves the clipping at the bottom of the checkbox downward.
Can you install the following test patch and tell us if the checkbox clipping bug is fixed for you?:
Intel:
http://juliette.neooffice.org/test/NeoOffice-3.3-Patch-7-Test-7-Intel.dmg
Patrick |
|
| Back to top |
|
|
amayze
The Merovingian
Joined: Oct 24, 2005
Posts: 561
Location: Edinburgh, Scotland
|
| Posted: Sat Jul 06, 2013 4:04 am Post subject: |
|
I've installed Patch 7 Test 7 and can confirm that there is now no clipping of the checkbox in the 3rd pane of the Address Book datasource wizard. There is still a tiny bit of clipping of the highlight when it is the active control, but that really is nit picking!
Andy |
|
| Back to top |
|
|
pluby
The Architect
Joined: Jun 16, 2003
Posts: 11949
|
| Posted: Sat Jul 06, 2013 7:34 am Post subject: |
|
| amayze wrote: | | I've installed Patch 7 Test 7 and can confirm that there is now no clipping of the checkbox in the 3rd pane of the Address Book datasource wizard. There is still a tiny bit of clipping of the highlight when it is the active control, but that really is nit picking! |
I noticed the clipping of the bottom row of focus ring pixels too. I was able to stop that from getting clipped but, unfortunately, when I did that, the OpenOffice.org code started clipping the top row of the focus ring. 
Patrick |
|
| Back to top |
|
|
pluby
The Architect
Joined: Jun 16, 2003
Posts: 11949
|
| Posted: Tue Jul 30, 2013 6:17 pm Post subject: |
|
FYI. The fix for the address book crashing bug and the checkbox clipping bug are in NeoOffice 2013 Beta 2. To download NeoOffice 2013 Beta 2, use the download link in this NeoWiki article.
Please note that the NeoOffice 2013 Beta 2 installer should find and update your existing NeoOffice 2013 Beta installation. If you don't have NeoOffice 2013 Beta already installed, it will install in /Applications/NeoOffice.app and overwrite any regular NeoOffice installation there if you have not renamed it. So, if you have NeoOffice 3.3 installed, we recommend that you rename it before installing NeoOffice 2013 Beta 2.
NeoOffice Secure Edition testers: NeoOffice 2013 Beta 2 is incompatible with NeoOffice Secure Edition so if you have one of the NeoOffice Secure Edition versions installed, we recommend that you delete your NeoOffice Secure Edition user preference files by executing the following command in a Terminal window before installing NeoOffice 2013 Beta 2:
| Quote: | | rm -Rf ~/Library/Containers/org.neooffice.NeoOfficeSecureEdition/Data/Library/Preferences/NeoOfficeSecureEdition |
Edit by pluby: added special steps for NeoOffice Secure Edition testers.
Patrick
Last edited by pluby on Wed Aug 07, 2013 9:04 am; edited 1 time in total |
|
| Back to top |
|
|
pluby
The Architect
Joined: Jun 16, 2003
Posts: 11949
|
| Posted: Sat Aug 03, 2013 10:01 pm Post subject: |
|
FYI. I have included the fix for this crashing bug in NeoOffice 3.3 Patch 8. The patch can be downloaded from the NeoOffice patch download page.
Patrick |
|
| Back to top |
|
|
|
