| View previous topic :: View next topic |
| Author |
Message |
pluby
The Architect
Joined: Jun 16, 2003
Posts: 11949
|
 Posted: Sun Oct 06, 2013 9:22 am Post subject: Cocoa-based tab items and tab borders |
|
As part of our plans to use Cocoa instead of the Apple's deprecated HITheme functions, I have reimplemented NeoOffice's native tab items and tab borders.
The following test patches include new Cocoa-based tab components. If there are no bugs, you should see no change in behavior when running any version of Mac OS X 10.7.
Can anyone install either of the following test patches and tell us if any tab items or the tab border appear to be drawn incorrectly? I spent most of my time testing the tabs in the dialog that is displayed when you select the Format :: Paragraph menu item in Writer:
NeoOffice 3.3:
http://juliette.neooffice.org/test/NeoOffice-3.3-Patch-10-Test-1-Intel.dmg
NeoOffice 2013:
http://juliette.neooffice.org/test/NeoOffice-2013.1-Test-1-Intel.dmg
Patrick |
|
| Back to top |
|
 |
revsmitty
Keymaker
Joined: May 15, 2005
Posts: 94
Location: Iowa, USA
|
| Posted: Tue Oct 08, 2013 2:16 pm Post subject: |
|
| I didn't find any that looked suspicious. NeoOffice 2013.1 |
|
| Back to top |
|
|
James3359
The Merovingian
Joined: Jul 05, 2005
Posts: 685
Location: North West England
|
| Posted: Wed Oct 09, 2013 12:54 am Post subject: |
|
These both look OK to me on the basis of checking a couple of different items.
James
_________________
MacBook Pro
13-inch, Mid 2012
Processor 2.5 GHz Intel Core i5
Memory 4 GB 1600 MHz DDR3
Graphics Intel HD Graphics 4000 512 MB
OS X 10.9.3 (13D65) |
|
| Back to top |
|
|
ovvldc
Captain Naiobi
Joined: Sep 13, 2004
Posts: 2352
Location: Zürich, CH
|
| Posted: Wed Oct 09, 2013 2:57 am Post subject: |
|
Looks fine to me as well. I did notice, however, that some of the buttons seem a bit tight (see bottom of the attached window-shot).
Best wishes,
Oscar
_________________
"What do you think of Western Civilization?"
"I think it would be a good idea!"
- Mohandas Karamchand Gandhi |
|
| Back to top |
|
|
pluby
The Architect
Joined: Jun 16, 2003
Posts: 11949
|
| Posted: Wed Oct 09, 2013 9:11 am Post subject: |
|
| ovvldc wrote: | | Looks fine to me as well. I did notice, however, that some of the buttons seem a bit tight (see bottom of the attached window-shot). |
IIRC, the OpenOffice.org code hardcoes button widths to barely fit the longest English or German button label. I am not sure that I can fix this given that the hardcoding of widths is scattered throughout the OpenOffice.org code, but I will check and see if the central OpenOffice.org code that that calls our button drawing code might allow for some adjustment of width based on text width. If so, I might be able to tack on a few pixels and see if that results in any clipping of button ends.
I will post when I have some news to report.
Patrick |
|
| Back to top |
|
|
ovvldc
Captain Naiobi
Joined: Sep 13, 2004
Posts: 2352
Location: Zürich, CH
|
| Posted: Wed Oct 09, 2013 10:11 am Post subject: |
|
Hey Patrick,
If it is hardcoded, don't worry about it. I would call it a minor aesthetic issue, and there are much more important things to get right.
Best wishes,
Oscar
_________________
"What do you think of Western Civilization?"
"I think it would be a good idea!"
- Mohandas Karamchand Gandhi |
|
| Back to top |
|
|
pluby
The Architect
Joined: Jun 16, 2003
Posts: 11949
|
| Posted: Tue Oct 15, 2013 10:12 am Post subject: |
|
I found that code that sets the button sizes in the Format :: Paragraph menu's dialog. Unfortunately, the buttons sizes are hardcoded.
Fortunately, what you see only occurs on Mac OS 10.6 Snow Leopard. On newer versions of Mac OS X, buttons have a much more rectangular shape (see screen snapshot below) so while the hardcoded button sizes are still there, the effect is less glaring.
Patrick |
|
| Back to top |
|
|
ovvldc
Captain Naiobi
Joined: Sep 13, 2004
Posts: 2352
Location: Zürich, CH
|
| Posted: Tue Oct 15, 2013 10:59 am Post subject: |
|
Which works for me, as I moved to a new MBA over the weekend  .
Thanks for checking!
_________________
"What do you think of Western Civilization?"
"I think it would be a good idea!"
- Mohandas Karamchand Gandhi |
|
| Back to top |
|
|
|
