View previous topic :: View next topic |
Author |
Message |
pluby The Architect
Joined: Jun 16, 2003 Posts: 11949
|
Posted: Sun Jun 18, 2006 10:22 am Post subject: Small change in Neo 2.0 build |
|
FYI. In order to fix bug bug 1521, I had to add a new module to the Neo build. The new module - bridges - contains the assembler for each combination of OS and chip that is needed to run OOo's UNO engine. While most of this code worked, it did not handle certain types of C++ method signatures and would crash so I have modified the OOo bridges code to fix this bug.
If you already have a HEAD checkout of the Neo code, you can update your workspace by doing a "cvs update" once (to get the modified existing files), and then doing a "cvs update -d bridges" to get the new module).
Patrick |
|
Back to top |
|
|
OPENSTEP The One
Joined: May 25, 2003 Posts: 4752 Location: Santa Barbara, CA
|
Posted: Sun Jun 18, 2006 10:30 am Post subject: |
|
Thanks for finding and fixing this. I've looked at the bridges code before when doing the x86 stuff in 1.1 (there gcc4 was the stumbling block, not the bridge) and, like the uno typing code, is probably the *least* fun place of OOo since it really makes apparent parts this whole codebase are built like a house of cards.
ed |
|
Back to top |
|
|
Samwise Captain Naiobi
Joined: Apr 25, 2006 Posts: 2315 Location: Montpellier, France
|
Posted: Sun Jun 18, 2006 10:40 am Post subject: |
|
What a timely announcement ! I just updated my HEAD build about half an hour ago
I do have a new folder called "bridges". |
|
Back to top |
|
|
OPENSTEP The One
Joined: May 25, 2003 Posts: 4752 Location: Santa Barbara, CA
|
Posted: Sun Jun 18, 2006 10:47 am Post subject: |
|
For those who are unaware, "bridges" contains the code that allows OOo itself to function. It provides the platform and compiler specific assembly glue that allows UNO code to run properly on any given architecture.
This bug lies at the heart of OOo running on Mactel since *everything* goes through bridges.
We now have a correct bridge and, by extension, a more stable implementation of OOo than OOo itself (when running on Mactel).
Go Patrick. You da man.
ed |
|
Back to top |
|
|
ovvldc Captain Naiobi
Joined: Sep 13, 2004 Posts: 2352 Location: Zürich, CH
|
Posted: Sun Jun 18, 2006 3:46 pm Post subject: |
|
OPENSTEP wrote: | We now have a correct bridge and, by extension, a more stable implementation of OOo than OOo itself (when running on Mactel).
Go Patrick. You da man. |
No kidding! I haven't done assembler in 18 or so years (on a C64) and I do not much care to go back to these days... After two years, you still manage to surprise me (in a positive way).
I trust this is all going back to the OOo codebase? Since it the source is LGPL anyway. It would be so nice to stuff Eric's next rant with a definitive and hard core contribution...
Best wishes,
Oscar _________________ "What do you think of Western Civilization?"
"I think it would be a good idea!"
- Mohandas Karamchand Gandhi |
|
Back to top |
|
|
OPENSTEP The One
Joined: May 25, 2003 Posts: 4752 Location: Santa Barbara, CA
|
Posted: Sun Jun 18, 2006 7:27 pm Post subject: |
|
ovvldc wrote: | I trust this is all going back to the OOo codebase? Since it the source is LGPL anyway. |
Our fixes are publicly available under the full GPL license only under clause 3 of the LGPL. While we may choose to relicense certain portions of code in the future, for now there are no plans to do so.
ed |
|
Back to top |
|
|
pluby The Architect
Joined: Jun 16, 2003 Posts: 11949
|
Posted: Tue Jun 20, 2006 8:40 am Post subject: |
|
I had to add one more module to fix bug 1524. The new module is lingucomponent. So, if you already have a HEAD checkout of the Neo code, you can update your workspace by doing a "cvs update" once (to get the modified existing files), and then doing a "cvs update -d bridges lingucomponent" to get the new modules.
Patrick |
|
Back to top |
|
|
|