Crash when printing

[amayze]

I'd had NeoOffice open for a while with no windows open. I returned to it, opened two old documents, and edited one of them, which I then wanted to print.

I type Cmd-P.
The print dialogue came up.
I pressed OK
The little NeoOffice printing window came up with the usual cancel button.
Nothing else happened!
I clicked cancel.
Clicking on the window I'd tried to print just beeps.
Clicking on the other document works ok.
I tried to close the edited document that I had tried to print.
Clicked through the do you want to save changes dialogues, saying Yes.
The document saved then NeoOffice crashed.

At no point did NeoOffice redraw the hung window. It still had all the noon-printables showing that appear when you print and the image was not displayed.

Sample of hung NeoOffice and Crash log attached. Also I found this in the console:

[pluby]

Thank you for the sample and the crash log. I could not reproduce the hanging that you see, but the sample indicates that the hang when printing was occurring in the same place as in this post of yours so it looks like my fix for that other bug was only a partial fix.

I suspect that the crash is a side effect of the document being stuck in the middle of printing so I will focus on reimplementing my fix for the other bug that you reported first.

Patrick

[pluby]

I removed the old fix for the bug that you originally reported in this forum topic and implemented a new fix that hopefully catches all cases of this bug.

After some debugging, I found that this bug occurs when NeoOffice's underlying OpenOffice.org code tries to reload a linked image file while it is still in the process of being asynchronously loaded. So, I modified the OpenOffice.org linked file handling code to allow any pending events before checking if the linked file needs to be reloaded. Hopefully, this will ensure that the previous asynchronous loading operation for the same linked file is complete and a second reload is never started.

Can you install the following test patch and tell us if any hanging still occurs when there is a linked image in your document?:

Intel:
http://sally.neooffice.org/test/NeoOffice-3.3-Patch-3-Test-9-Intel.dmg

Patrick

[pluby]

After posting yesterday's test patch, I found what I believe is the real cause of these bugs with linked images when printing. The real cause is that when I did the "de-Javafication" work, I inadvertently added a bug that causes internal OpenOffice.org events to be ignored when a native dialog is displayed. These internal OpenOffice.org events need to be dispatched and when they get ignored, I see the bugs that you reported.

I have copied the logic that was in the Java code into the current NeoOffice code so that internal OpenOffice.org events are never ignored in the following test patch so please test the following test patch instead of yesterday's test patch:

Intel:
http://sally.neooffice.org/test/NeoOffice-3.3-Patch-3-Test-10-Intel.dmg

Patrick

[amayze]

Happy New Year!

I've installed Patch 3 Test 10. Printing seems to work fine, though I haven't done much of it yet. What is noticeable though is that images no longer disappear and then re-draw after clicking Print in the Print sheet.

Thanks for all your work Patrick and I hope 2013 is a prosperous one for you and yours and the NeoOffice project as a whole.

Cheers,

Andy

[pluby]

FYI. I have included the fix that was in the previous test patch in NeoOffice 3.3 Patch 4. The patch can be downloaded from the NeoOffice 3.3 patch download page.

Patrick