Welcome to NeoOffice developer notes and announcements
NeoOffice
Developer notes and announcements
 
 

This website is an archive and is no longer active
NeoOffice announcements have moved to the NeoOffice News website


Support
· Forums
· NeoOffice Support
· NeoWiki


Announcements
· Twitter @NeoOffice


Downloads
· Download NeoOffice


  
NeoOffice :: View topic - Selection colour in Calc NeoOffice 3.0
Selection colour in Calc NeoOffice 3.0
 
   NeoOffice Forum Index -> NeoOffice Beta Releases
View previous topic :: View next topic  
Author Message
Frieder2008
Agent


Joined: May 03, 2008
Posts: 19

PostPosted: Sat Dec 27, 2008 10:29 am    Post subject: Selection colour in Calc NeoOffice 3.0

Hi,

I'm using NeoOffice for almost a year since I changed from Windows to Apple and still find it very usable and elegant and very suitable for my needs. You did a great job, creating such a product for the Mac.

Looking into the new OpenOffice 3.0, the base for the upcoming new version of NeoOffice y discovered something I don't like at all and I hope you might get it better in the new NeoOffice:

In Calc, selecting a couple of cells with click-draw in NeoOffice, up to now the selection is highlighted in black, which is very easy to recognise. Now, in OpenOffice 3.0, the selection appears highlighted in a very light sky-blue, almost impossible to figure out what is selected. I don't know, if I did something wrong, but is there any option to change the colour of the selected area to what it was before? Or could you consider the possibility to leave the selection colour in black as it was in the “old, beloved” NeoOffice 2.2?

Regards


Frieder
Back to top
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11949

PostPosted: Sat Dec 27, 2008 10:40 am    Post subject:

Starting with OpenOffice.org 3.0, the system highlight color is used. By default, Mac OS X sets the system highlight color to light blue.

So, to change the highlight color in OpenOffice.org 3.0 and NeoOffice 3.0 Early Access, launch the System Preferences application, click on the Appearance icon, and change the Highlight Color to whatever color that you want.

Edit: note that after changing the system highlight color, you will need to quit and restart OpenOffice.org 3.0 or NeoOffice 3.0 Early Access.

Patrick
Back to top
HendrikPon
Agent


Joined: Jan 18, 2009
Posts: 18

PostPosted: Sun Jan 18, 2009 9:48 am    Post subject:

I agree with the OP about the very faint highlighting colour
in OpenOffice/NeoOffice 3.

I don't mind at all the Calc uses the system highlight colour.
But the OO3 code is modifying the highlight colour in such a way that it becomes much lighter.
I used the DigitalColor Meter utility to get the following

Mac OS X highlight color: RGB=B7,D5,FE (hex)
OO3/NeoOffice3 color: RGB=ED,F5,FF (hex).

I have changed my highlight colour temporarily to

My colour: RGB=92,BF,FE
OO3/NeoOffice3 colour= RGB=E3,EF,FF

It appears that OO3 is not using the system highlight colour unmodified. It seems to do something and making it less readable.

Berend Hasselman

Mac OS X 10.5.6 (Intel)
Appearance: Graphite with standard Blue as highlight colour.
Back to top
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11949

PostPosted: Sun Jan 18, 2009 10:38 am    Post subject:

Yes, we know that this is a change in the OpenOffice.org 3.0 code and neither Ed nor I like this change that the OpenOffice.org engineers made.

The problem is that neither Ed nor I have any familiarity with the hundreds of C++ source code files that make up Calc and, as a result, this is not likely something I am going to easily find and fix. The entire OpenOffice.org source code is over 30,000 source files and while we have gained quite a bit of depth of knowledge of the nearly 1,000 that corner screen display, printing, and file reading and writing, that knowledge took nearly 6 years to acquire.

This is why we must limit our scope to only making a native Mac OS X version OpenOffice.org: gaining knowledge the other 95% of the OpenOffice.org code is way beyond the reach of only two people. Sun Microsystems employs several dozen engineers to work on the other 95% of the OpenOffice.org code and it is just not feasible for us to undo even a fraction of the changes that those engineers make.

If you feel that the background color needs to be changed, you really should file a bug in the OpenOffice.org issue tracker to get it on the radar of the core OpenOffice.org developers and if they fix the bug, the new behavior will get included in a future release of NeoOffice:

http://qa.openoffice.org/issue_handling/pre_submission.html

Note : our advice is to not mention NeoOffice as mentioning NeoOffice may cause OOo volunteers to accidentally close it without actually reviewing your bug.

Patrick
Back to top
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11949

PostPosted: Sun Jan 18, 2009 3:20 pm    Post subject:

I forget to mention that I moved this topic into the NeoOffice Early Access Program Support forum so that hopefully people will find the workaround for this change that OpenOffice.org's engineers made:

1. Launch the System Preferences application and click on the Appearance icon
2. Click on the Highlight Color list box and select a darker color. Note that if you click the Other item at the end of list, a dialog will appear that will let you set the color to any color that you want.

Patrick
Back to top
Lorinda
Captain Mifune


Joined: Jun 20, 2006
Posts: 2051
Location: Midwest, USA

PostPosted: Sun Jan 18, 2009 7:13 pm    Post subject:

If you do file an issue/bug report with OpenOffice.org, please post the link to it here. Then others of us who find this annoying can vote for the bug as well.

Unfortunately, the problem with Patrick's workaround is that then the highlight color for other apps is too dark, at least for my tastes. Even the darker half of the "gradient" Calc's the column and row header becomes too dark. But I only played around with the preset color options. Maybe if one uses the "other" option, a decent compromise color could be found.

I don't use Calc enough at this point to take the tie to mess around to find the right color, but that could change in the future.

Lorinda
Back to top
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11949

PostPosted: Sun Jan 18, 2009 9:46 pm    Post subject:

I have good news and bad news.

The good news is that, through some lucky experimentation, I found the Calc file that the OpenOffice.org engineers changed. I was able to compare that file to the same file in the OpenOffice.org 2.2.1 code and the new highlighting code that they added was pretty easy to identify.

The bad news is that their new code is drawing the system highlight color at 75% transparency. That is really, really light so I changed it to only 25% transparency but that was worse as they draw the highlight color *over* the existing cell data. So, when you use only 25% transparency, the existing cell data is barely visible. If I turned off transparency, the the cell data was completely obscured by the system highlight color.

Since lessening the transparency is clearly not going to work as it makes the cell contents unreadable, I changed the code to match the OpenOffice.org 2.2.1 code. What does that mean? It means that starting with the next test patch, the NeoOffice 2.2.5 behavior will be used: selecting will "invert" the background color.

More bad news: there are no configuration settings that controls which selection drawing style is used so once I switch to the NeoOffice 2.2.5, there is no option to use the OpenOffice.org 3.0 behavior. To get the OpenOffice.org behavior, you will need to use OpenOffice.org 3.0.

It will take me at least a day or two to get the next test patch out. But when I have it out, I will post links in this forum topic.

Patrick
Back to top
sardisson
Town Crier
Town Crier


Joined: Feb 01, 2004
Posts: 4588

PostPosted: Sun Jan 18, 2009 9:50 pm    Post subject:

Revenge of XOR? Razz

Smokey

_________________
"[...] whether the duck drinks hot chocolate or coffee is irrelevant." -- ovvldc and sardisson in the NeoWiki
Back to top
HendrikPon
Agent


Joined: Jan 18, 2009
Posts: 18

PostPosted: Mon Jan 19, 2009 9:22 am    Post subject: Re: Selection colour in Calc NeoOffice 3.0

Reverting to the 2.2.1 code seems the best thing to do.
As you have explained it would need some surgery to get it right in the new code.

I also don't really want to change the highlight colour in Mac OS X.

I also tried the "grey" as highlight colour: you can't discern the selection.

Your plan seems the best option, at least for the time being.

Berend
Back to top
yoxi
Cipher


Joined: Sep 07, 2004
Posts: 1799
Location: Dawlish, Devon

PostPosted: Mon Jan 19, 2009 10:49 am    Post subject:

My tuppence-ha'penny: I prefer using the system 'select' colour (which I've now changed anyway) to reverting to the v2 invert code. It's good to have control over the colour, so that when I see that colour I immediately know it's what's selected.

To each their own, though Sad
Back to top
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11949

PostPosted: Mon Jan 19, 2009 11:03 am    Post subject:

yoxi wrote:
My tuppence-ha'penny: I prefer using the system 'select' colour (which I've now changed anyway) to reverting to the v2 invert code. It's good to have control over the colour, so that when I see that colour I immediately know it's what's selected.

To each their own, though Sad


I am sure other people will miss the pretty highlighting. However, I have to say that the way OpenOffice.org implemented their highlighting just does not work right. The approach of drawing the selection color *over* the existing cell contents and grid was probably easy to implement, but for it to work, you have to make the selection color almost completely transparent.

What this comes down to is a choice between the following:

- Make the selection color pretty but difficult to see for a significant percentage of users with poor eyesite or older

or

- Make it not so pretty but easy to see for the vast majority of users

Ideally, fixing the OpenOffice.org code to draw the selection color *under* the cell contents would make all users happy. However, fixing their code to work correctly would require reimplementing lots of their Calc code and, frankly, neither Ed nor I really have the spare time to clean up the messes that the OpenOffice.org engineers may create.

Luckily, in this case, reverting the code was not too troublesome so that is really the most feasible solution.

Patrick
Back to top
yoxi
Cipher


Joined: Sep 07, 2004
Posts: 1799
Location: Dawlish, Devon

PostPosted: Mon Jan 19, 2009 12:40 pm    Post subject:

Fair 'nuff - though I have bad eyesight and do not find the current v3 EA implementation at all hard to read when cells are selected - perhaps it depends on how dark a 'selection colour' you choose in the first place - I always choose a fairly light one because Mail always adds too much dark to it. Oh, and mine is green (as are most of my background colours, desktop picture etc.) so the contrast is a lot more obvious even with a paleish colour.

I'll take what I can get, though Smile

- padmavyuha
Back to top
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11949

PostPosted: Mon Jan 19, 2009 2:44 pm    Post subject:

I have posted a test patch that has the old OpenOffice.org 2.2.1 Calc selection code. Can anyone install the following test patch and tell us if the behavior is not the same as NeoOffice 2.2.5?:

Intel:
http://joe.neooffice.org/test/NeoOffice-3.0_Early_Access-Patch-0-Test-2-Intel.dmg

PowerPC:
http://joe.neooffice.org/test/NeoOffice-3.0_Early_Access-Patch-0-Test-2-PowerPC.dmg

Patrick
Back to top
Jim
Councilperson


Joined: Jun 21, 2003
Posts: 173
Location: Selmer, Tennessee

PostPosted: Mon Jan 19, 2009 4:36 pm    Post subject:

I installed this patch to correct the flickering checkboxes and other controls. Just tried it, and it functions more or less correctly.

You cannot, however, do a diagonal fill selection. Pulling the fill handle down or to the right works properly; but you can't do a diagonal fill-drag.

_________________
Jim Plante
MacOS X 10.6.34, MacBook 2GHz C2Duo, 2gb, Neo 3.1.1 p 1
Back to top
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11949

PostPosted: Mon Jan 19, 2009 5:45 pm    Post subject:

Jim wrote:
You cannot, however, do a diagonal fill selection. Pulling the fill handle down or to the right works properly; but you can't do a diagonal fill-drag.


I do not think OpenOffice.org ever supported diagonal fill as I get the same behavior in OpenOffice.org 2.2.1 through 3.0.

FWIW, Excel 2008 does not support this either.

Patrick
Back to top
Display posts from previous:   
   NeoOffice Forum Index -> NeoOffice Beta Releases All times are GMT - 7 Hours
Goto page 1, 2  Next
Page 1 of 2

 
You can post new topics in this forum
You can reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Powered by phpBB © 2001, 2005 phpBB Group

All logos and trademarks in this site are property of their respective owner. The comments are property of their posters, all the rest © Planamesa Inc.
NeoOffice is a registered trademark of Planamesa Inc. and may not be used without permission.
PHP-Nuke Copyright © 2005 by Francisco Burzi. This is free software, and you may redistribute it under the GPL. PHP-Nuke comes with absolutely no warranty, for details, see the license.