Welcome to NeoOffice developer notes and announcements
NeoOffice
Developer notes and announcements
 
 

Download or installation problems? Try these steps
Problems after upgrading to NeoOffice 2017? Try these steps


Support
· NeoOffice Support
· NeoWiki


Announcements
· Twitter @NeoOffice


Downloads
· Download NeoOffice


RSS Feeds
· Announcements Only
· All Posts


  
NeoOffice :: View topic - Problem with comments in docx files
Problem with comments in docx files
 
Post new topic   Reply to topic    NeoOffice Forum Index -> NeoOffice Releases
View previous topic :: View next topic  
Author Message
benst
Captain


Joined: May 25, 2004
Posts: 72
Location: The Netherlands

PostPosted: Wed Feb 15, 2012 9:55 am    Post subject: Problem with comments in docx files Reply with quote

Hi,

I have attached a .docx file with six comments in it. In NeoOffice 3.2.1p3, these comments are all merged together and repeated in each of the six comment boxes. I opened the file in LibreOffice 3.5.0 and it imports as expected there, so I assume this bug has been fixed somewhere along the line. Would it be possible to fix this in NeoOffice too?

Kind regards,
Ben
Back to top
View user's profile Send private message
benst
Captain


Joined: May 25, 2004
Posts: 72
Location: The Netherlands

PostPosted: Wed Feb 15, 2012 10:00 am    Post subject: Reply with quote

I see some info related to this bug here:

https://issues.apache.org/ooo/show_bug.cgi?id=113059
https://bugs.freedesktop.org/show_bug.cgi?id=34489

Kind regards,
Ben
Back to top
View user's profile Send private message
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11910
Location: California, USA

PostPosted: Wed Feb 15, 2012 10:24 am    Post subject: Reply with quote

Ben,

benst wrote:
I see some info related to this bug here:

https://issues.apache.org/ooo/show_bug.cgi?id=113059
https://bugs.freedesktop.org/show_bug.cgi?id=34489


I found the same bug reports as well. I will look at the LibreOffice patch and see if I can backport their patch into the NeoOffice code. Since I had backported the LibreOffice 3.3.4.1 .docx import code in NeoOffice 3.2.1 Patch 1, I am reasonably confident that I should be able to backport their patch.

I will post again when I have some news to report. If I am able to backport their patch, I should be able to post a test patch that you can try by the end of this week.

Patrick
Back to top
View user's profile Send private message Visit poster's website
benst
Captain


Joined: May 25, 2004
Posts: 72
Location: The Netherlands

PostPosted: Wed Feb 15, 2012 10:29 am    Post subject: Reply with quote

Thank you!

Kind regards,
Ben
Back to top
View user's profile Send private message
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11910
Location: California, USA

PostPosted: Wed Feb 15, 2012 12:06 pm    Post subject: Reply with quote

I have backported the patch in LibreOffice bug 34489 into NeoOffice 3.2.1 and that patch appears to fix the .docx comments bug.

Can you install the test patch and tell us if the bug is fixed for you?:

Intel:
http://sally.neooffice.org/test/NeoOffice-3.2.1-Patch-3-Test-6-Intel.dmg

Patrick
Back to top
View user's profile Send private message Visit poster's website
benst
Captain


Joined: May 25, 2004
Posts: 72
Location: The Netherlands

PostPosted: Wed Feb 15, 2012 12:18 pm    Post subject: Reply with quote

Hi Patrick,

Looks good! The original document that I had problems with now shows the correct comments too. I'll do some more testing and let you know.

Kind regards,
Ben
Back to top
View user's profile Send private message
benst
Captain


Joined: May 25, 2004
Posts: 72
Location: The Netherlands

PostPosted: Wed Feb 15, 2012 1:18 pm    Post subject: Reply with quote

Hi Patrick,

No problems with another document either, so as far as I'm concerned the patch is ok. Thanks again for the extremely fast response, that was very helpful!

Kind regards,
Ben
Back to top
View user's profile Send private message
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11910
Location: California, USA

PostPosted: Wed Feb 15, 2012 2:33 pm    Post subject: Reply with quote

benst wrote:
No problems with another document either, so as far as I'm concerned the patch is ok. Thanks again for the extremely fast response, that was very helpful!


My fast response was made possible by the fact that a LibreOffice developer had already found the cause and wrote a fix for this bug. Without that developer's work, I likely would have eventually found the cause but it would have probably taken me many days of debugging work to find the cause. So, my thanks go to the LibreOffice developer who fixed this bug.

BTW, we will include the fix in the next official NeoOffice patch which will likely be released before the end of this month. I am implementing the last bits of functionality in this new feature request and once that work is done, the next official patch will be released.

Patrick
Back to top
View user's profile Send private message Visit poster's website
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11910
Location: California, USA

PostPosted: Tue Feb 21, 2012 6:24 pm    Post subject: Reply with quote

FYI. I have included the backported LibreOffice fix for this bug in NeoOffice 3.2.1 Patch 4. You can download the patch from the NeoOffice 3.2.1 patch download page.

Patrick
Back to top
View user's profile Send private message Visit poster's website
benst
Captain


Joined: May 25, 2004
Posts: 72
Location: The Netherlands

PostPosted: Wed Feb 22, 2012 9:46 am    Post subject: Reply with quote

Thanks!

Ben
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    NeoOffice Forum Index -> NeoOffice Releases All times are GMT - 7 Hours
Page 1 of 1

 
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Powered by phpBB © 2001, 2005 phpBB Group

All logos and trademarks in this site are property of their respective owner. The comments are property of their posters, all the rest © Planamesa Inc.
NeoOffice is a registered trademark of Planamesa Inc. and may not be used without permission.
PHP-Nuke Copyright © 2005 by Francisco Burzi. This is free software, and you may redistribute it under the GPL. PHP-Nuke comes with absolutely no warranty, for details, see the license.
Page Generation: 0.03 Seconds