OPENSTEP
The One
Joined: May 25, 2003
Posts: 4752
Location: Santa Barbara, CA
|
 Posted: Wed Mar 24, 2004 12:02 am Post subject: Fix to aqua/source/app/salinst.cxx |
|
I just committed what seems to be a fix to salinst.cxx. Basically, I'm trying to track down some crashers and thus far the only thoughts I have are that the heap is getting trashed somehow 
Anyway, while looking at SalInstance::Yield(), I noticed that there was an explicit [pTimeoutDate release] call on an NSDate that was returned from the fireDate method of NSTimer. I may have interpreted my bible (WWDC 2002 session 302) incorrectly, but I believe that NSTimer will have already taken care of memory management for the returned NSDate and the explicit release isn't necessary since we aren't retaining it ourselves in [VCLApplication getSALTimerTimeoutDate].
I'm unsure if it would have bad effects a la freeing a pointer already freed. Any thoughts?
ed |
|
