Welcome to NeoOffice developer notes and announcements
NeoOffice
Developer notes and announcements
 
 

This website is an archive and is no longer active
NeoOffice announcements have moved to the NeoOffice News website


Support
· Forums
· NeoOffice Support
· NeoWiki


Announcements
· Twitter @NeoOffice


Downloads
· Download NeoOffice


  
NeoOffice :: View topic - Crash when printing
Crash when printing
 
   NeoOffice Forum Index -> NeoOffice Releases
View previous topic :: View next topic  
Author Message
amayze
The Merovingian


Joined: Oct 24, 2005
Posts: 561
Location: Edinburgh, Scotland

PostPosted: Sat Dec 22, 2012 5:46 am    Post subject: Crash when printing

I'd had NeoOffice open for a while with no windows open. I returned to it, opened two old documents, and edited one of them, which I then wanted to print.

I type Cmd-P.
The print dialogue came up.
I pressed OK
The little NeoOffice printing window came up with the usual cancel button.
Nothing else happened!
I clicked cancel.
Clicking on the window I'd tried to print just beeps.
Clicking on the other document works ok.
I tried to close the edited document that I had tried to print.
Clicked through the do you want to save changes dialogues, saying Yes.
The document saved then NeoOffice crashed.

At no point did NeoOffice redraw the hung window. It still had all the noon-printables showing that appear when you print and the image was not displayed.

Sample of hung NeoOffice and Crash log attached. Also I found this in the console:
Code:
22/12/2012 12:34:55.042 com.apple.launchd.peruser.502[241]: ([0x0-0xd10d1].org.neooffice.NeoOffice[1514]) Job appears to have crashed: Abort trap: 6


I'm off on holiday now and won't be back at this machine till 3rd Jan. I'll have intermittent access to other Macs over the holiday period, so may be able to test patches.

Have a good Christmas Patrick and everyone else here too.

Cheers,

Andy
Back to top
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11949

PostPosted: Sat Dec 22, 2012 11:12 am    Post subject:

Thank you for the sample and the crash log. I could not reproduce the hanging that you see, but the sample indicates that the hang when printing was occurring in the same place as in this post of yours so it looks like my fix for that other bug was only a partial fix.

I suspect that the crash is a side effect of the document being stuck in the middle of printing so I will focus on reimplementing my fix for the other bug that you reported first.

Patrick
Back to top
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11949

PostPosted: Mon Dec 24, 2012 7:08 pm    Post subject:

I removed the old fix for the bug that you originally reported in this forum topic and implemented a new fix that hopefully catches all cases of this bug.

After some debugging, I found that this bug occurs when NeoOffice's underlying OpenOffice.org code tries to reload a linked image file while it is still in the process of being asynchronously loaded. So, I modified the OpenOffice.org linked file handling code to allow any pending events before checking if the linked file needs to be reloaded. Hopefully, this will ensure that the previous asynchronous loading operation for the same linked file is complete and a second reload is never started.

Can you install the following test patch and tell us if any hanging still occurs when there is a linked image in your document?:

Intel:
http://sally.neooffice.org/test/NeoOffice-3.3-Patch-3-Test-9-Intel.dmg

Patrick
Back to top
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11949

PostPosted: Tue Dec 25, 2012 11:06 pm    Post subject:

After posting yesterday's test patch, I found what I believe is the real cause of these bugs with linked images when printing. The real cause is that when I did the "de-Javafication" work, I inadvertently added a bug that causes internal OpenOffice.org events to be ignored when a native dialog is displayed. These internal OpenOffice.org events need to be dispatched and when they get ignored, I see the bugs that you reported.

I have copied the logic that was in the Java code into the current NeoOffice code so that internal OpenOffice.org events are never ignored in the following test patch so please test the following test patch instead of yesterday's test patch:

Intel:
http://sally.neooffice.org/test/NeoOffice-3.3-Patch-3-Test-10-Intel.dmg

Patrick
Back to top
amayze
The Merovingian


Joined: Oct 24, 2005
Posts: 561
Location: Edinburgh, Scotland

PostPosted: Thu Jan 03, 2013 4:42 am    Post subject:

Happy New Year!

I've installed Patch 3 Test 10. Printing seems to work fine, though I haven't done much of it yet. What is noticeable though is that images no longer disappear and then re-draw after clicking Print in the Print sheet.

Thanks for all your work Patrick and I hope 2013 is a prosperous one for you and yours and the NeoOffice project as a whole.

Cheers,

Andy
Back to top
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11949

PostPosted: Mon Jan 21, 2013 10:53 pm    Post subject:

FYI. I have included the fix that was in the previous test patch in NeoOffice 3.3 Patch 4. The patch can be downloaded from the NeoOffice 3.3 patch download page.

Patrick
Back to top
Display posts from previous:   
   NeoOffice Forum Index -> NeoOffice Releases All times are GMT - 7 Hours
Page 1 of 1

 
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Powered by phpBB © 2001, 2005 phpBB Group

All logos and trademarks in this site are property of their respective owner. The comments are property of their posters, all the rest © Planamesa Inc.
NeoOffice is a registered trademark of Planamesa Inc. and may not be used without permission.
PHP-Nuke Copyright © 2005 by Francisco Burzi. This is free software, and you may redistribute it under the GPL. PHP-Nuke comes with absolutely no warranty, for details, see the license.