| View previous topic :: View next topic |
| Author |
Message |
pluby
The Architect
Joined: Jun 16, 2003
Posts: 10959
Location: California, USA
|
 Posted: Fri Feb 06, 2009 10:31 pm Post subject: Trinity now supports attachments |
 |
|
It has always been very annoying that we have users could not attach files to their posts and we have had to force them to use a third party upload service or create a Bugzilla account and file a bug.
Since we completed the recent upgrade to the latest phpNuke version (phpNuke is the software that we use for this site), I was able to add the phpBB Attachments module to our phpNuke installation. So now logged in users can attach one or more images, documents, crash logs, etc. to each forum post.
To ensure that Google and other search engines do not index people's attachments, any attachments that are posted on this site will not be visible to anonymous users. To see any attachments, you must log into this site first.
My hope is that by adding this functionality, we can reduce our need for Bugzilla and consolidate more of our support into one single site. So please let us know if you see any problems with the new attachments feature.
Patrick |
|
| Back to top |
|
 |
yoxi
Cipher
Joined: Sep 07, 2004
Posts: 1799
Location: Dawlish, Devon
|
| Posted: Sat Feb 07, 2009 2:14 am Post subject: |
|
|
Smart - a sticky in the Support section on how to attach files would save a few messages too  |
|
| Back to top |
|
|
yoxi
Cipher
Joined: Sep 07, 2004
Posts: 1799
Location: Dawlish, Devon
|
| Posted: Sat Feb 07, 2009 2:27 am Post subject: |
|
|
I've just added an explanatory Sticky about this to the Support forum - feel free to edit it or whatever if you think it isn't clear enough or I've missed something out.
The only thing obviously not working yet is that the Allowed Extensions and Sizes link goes nowhere.
I also think the dividing horizontal line could be heavier to make a sharper distinction between the end of the message and the attachment section, but that's just personal taste.
I also think it would look better left-justified rather than centred, given that the message text itself is left-justified. |
|
| Back to top |
|
|
pluby
The Architect
Joined: Jun 16, 2003
Posts: 10959
Location: California, USA
|
| Posted: Sat Feb 07, 2009 9:52 am Post subject: |
|
|
| yoxi wrote: | | I've just added an explanatory Sticky about this to the Support forum - feel free to edit it or whatever if you think it isn't clear enough or I've missed something out. |
Thanks for doing that. I added one additional sentence to remind people that all attachments are public so don't post any confidential data.
| yoxi wrote: | | The only thing obviously not working yet is that the Allowed Extensions and Sizes link goes nowhere. |
I found the source of the broken link in their code and corrected the link so this should be working now.
Patrick |
|
| Back to top |
|
|
yoxi
Cipher
Joined: Sep 07, 2004
Posts: 1799
Location: Dawlish, Devon
|
| Posted: Sat Feb 07, 2009 10:35 am Post subject: |
|
|
The system works well - I fell foul of trying to add an attachment before typing any message, and it doesn't like that. I've tweaked my text a little too, as I hadn't noticed that after you attach a file, it shows up listed below the Add an Attachment section.
I don't recognise most of the plain text file extensions! |
|
| Back to top |
|
|
pluby
The Architect
Joined: Jun 16, 2003
Posts: 10959
Location: California, USA
|
| Posted: Sat Feb 07, 2009 11:12 am Post subject: |
|
|
| yoxi wrote: | | I don't recognise most of the plain text file extensions! |
Don't worry about that. The key extension is "*" which is the catch all for any unmatched extensions. Most of the extensions are merely a hardcoded list in the Attachments extension software that we used.
Patrick |
|
| Back to top |
|
|
pluby
The Architect
Joined: Jun 16, 2003
Posts: 10959
Location: California, USA
|
| Posted: Sat Feb 07, 2009 11:25 am Post subject: |
|
|
| pluby wrote: | | Don't worry about that. The key extension is "*" which is the catch all for any unmatched extensions. Most of the extensions are merely a hardcoded list in the Attachments extension software that we used. |
I found that most of the file extensions are actually in a database table so I trimmed out all of the extraneous entries in that table so that "*" covers all documents.
Patrick |
|
| Back to top |
|
|
sardisson
Town Crier
Joined: Feb 01, 2004
Posts: 4574
|
| Posted: Sat Feb 07, 2009 11:43 am Post subject: |
|
|
Nice work, gentlemen!
Smokey
_________________
"[...] whether the duck drinks hot chocolate or coffee is irrelevant." -- ovvldc and sardisson in the NeoWiki |
|
| Back to top |
|
|
yoxi
Cipher
Joined: Sep 07, 2004
Posts: 1799
Location: Dawlish, Devon
|
| Posted: Sat Feb 07, 2009 1:16 pm Post subject: |
|
|
| pluby wrote: | | pluby wrote: | | Don't worry about that. The key extension is "*" which is the catch all for any unmatched extensions. Most of the extensions are merely a hardcoded list in the Attachments extension software that we used. |
I found that most of the file extensions are actually in a database table so I trimmed out all of the extraneous entries in that table so that "*" covers all documents.
Patrick |
Hmm... so the file types thing is redundant, really? Just relevant for letting people know the size limit is 5Mb? |
|
| Back to top |
|
|
pluby
The Architect
Joined: Jun 16, 2003
Posts: 10959
Location: California, USA
|
| Posted: Sat Feb 07, 2009 1:57 pm Post subject: |
|
|
| yoxi wrote: | | Hmm... so the file types thing is redundant, really? Just relevant for letting people know the size limit is 5Mb? |
Pretty much. I think the authors of the code wanted to enable the ability to set different size limits on different file extensions and disable certain file extensions altogether. The "*" wildcard extension is really a hack that I was able to hack into their code as I felt that given that the number of virus or malware attachments has been virtually zero in Bugzilla, it was OK to let people post whatever file extensions they think are OK for, like in Bugzilla, we do not allow any inline display of attachments other than the few extensions listed as images.
Patrick |
|
| Back to top |
|
|
Samwise
Captain Naiobi
Joined: Apr 25, 2006
Posts: 2315
Location: Montpellier, France
|
| Posted: Sun Feb 08, 2009 3:16 pm Post subject: |
|
|
Not sure whether it's caused by this new feature, but since I saw Oscar's post about the feature, I keep seeing this:
I only see it next to the title of these two same topics, and I wonder what's causing this? |
|
| Back to top |
|
|
pluby
The Architect
Joined: Jun 16, 2003
Posts: 10959
Location: California, USA
|
| Posted: Sun Feb 08, 2009 5:12 pm Post subject: |
|
|
I found some HTML errors. I had added comments using PHP syntax where I should have used HTML syntax and maybe that was causing your browser to show question mark images.
If clear your web browser's cache and reload the page, do the question marks still appear?
Patrick |
|
| Back to top |
|
|
James3359
The Merovingian
Joined: Jul 05, 2005
Posts: 644
Location: North West England
|
| Posted: Mon Feb 09, 2009 4:15 am Post subject: |
|
|
| I am seeing this on thread titles where there is an attachment. I have emptied cache and refreshed pages, but it remains the same. (iBook 1.33 GHz 512 MB PowerPC G4, OS X 10.4.11 Safari 3.2.1) |
|
| Back to top |
|
|
yoxi
Cipher
Joined: Sep 07, 2004
Posts: 1799
Location: Dawlish, Devon
|
| Posted: Mon Feb 09, 2009 6:29 am Post subject: |
|
|
I get this ? behaviour in Safari (v3.2.1), but not at all in Firefox (v3.0.6). It appears to be:
| Code: | | <img src="images/icon_clip.gif" alt="" border="0" /> |
not displaying at all in FF, and displaying as a ? in Safari. |
|
| Back to top |
|
|
pluby
The Architect
Joined: Jun 16, 2003
Posts: 10959
Location: California, USA
|
| Posted: Mon Feb 09, 2009 9:50 am Post subject: |
|
|
| yoxi wrote: | I get this ? behaviour in Safari (v3.2.1), but not at all in Firefox (v3.0.6). It appears to be:
not displaying at all in FF, and displaying as a ? in Safari. |
Ahah! That explains it. I found where the default images folder is set in the administration pages and have updated it. If you reload the pages, this should now work.
Patrick |
|
| Back to top |
|
|
|
Forum FAQ
Search
Usergroups
Profile
Private Messages
Log in
