Image handling performance improvements

amayze · Posted: Fri Dec 15, 2006 9:24 am Post subject:

Test 4 seems to have caused a visual artefact to appear in spreadsheets.

1. Type something in to a cell and press right arrow - a black line appears in the cell you have just moved to.

2. Move the highlight over a cell with data in it, press delete - a black line appears in the cell.

3. Paste data in to an cell - the same black line appears.

It can be removed by scrolling the affected cells off screen and back again or clicking in the formula bar with the affected cell highlighted.

Didn't see this with vanilla Patch 10.

Andy.

pluby · The Architect Joined: Jun 16, 2003 Posts: 11949

FYI. I have fixed the Calc bug and backed out some of the code that proved to be slower in test patch 4 and I have posted a new test patch in bug 2034.

Patrick

Samwise · Posted: Sat Dec 16, 2006 3:02 am Post subject:

For me, Patch 10 Test 5 is marginally faster than Test 2. Still not as fast as Test 1, but definitely better.

I didn't test Calc before installing the patch, but when I use Calc later today I should be able to test the fix for Andy's bug.

Edit : The fix appears to be working.

amayze · Posted: Sat Dec 16, 2006 4:35 am Post subject:

Yup, Test 5 fixed the calc bug for me.
And I guess the presentation is a little faster? Haven't timed it exactly, but its certainly usable still.

Andy.

Samwise · Posted: Sat Dec 16, 2006 5:50 am Post subject:

Yes, I'm under the impression that Test 5 is the fastest since Test 1 (and it's been confirmed by my stopwatch).

amayze · Posted: Sat Dec 16, 2006 6:43 am Post subject:

Lorinda · Posted: Sat Dec 16, 2006 6:57 am Post subject:

I can also verify that text patch 5 is slightly faster than patch 4, and it has cleared the calc bug Andy saw and I was able to reproduce.

With test patch 4, the blurring returned to the effect uncover-left-down (although uncover-right-down was fine) and diagonal squares was quite slow. But test patch 5 has fixed the blurring again, and the diagonal squares seemed faster. (I hadn't timed the diagonal squares because I presumed it was related to the XORing issue.) I had written up the patch 4 issues I was seeing, but I must have gotten interrupted before I submitted them, as I they never made it to trinity.

Samwise · Posted: Sat Dec 16, 2006 9:58 am Post subject:

I experience an odd bug when printing to PDF with Patch 10 Test 5. See the attached documents in bug 2034.

pluby · The Architect Joined: Jun 16, 2003 Posts: 11949

FYI. I've added some comments to bug 2034 about the hanging and the printing problem. Can both of you take a look at my comments so I can figure these two items out?

Thanks,

Patrick

amayze · Posted: Sun Dec 17, 2006 2:37 pm Post subject:

pluby · The Architect Joined: Jun 16, 2003 Posts: 11949

FYI. I think that I have fixed the hanging and printing bugs in test patch 5 and I have posted a new test patch in bug 2034.

Patrick

Samwise · Posted: Mon Dec 18, 2006 12:33 pm Post subject:

Printing problem is fixed.

I noticed something though (although I'm not sure it's related to the patch at all) : when printing to PDF from the print dialog, the name of the produced file used to have the file extension in the name, and now it doesn't.

For example, filename.odt would become filename.odt - NeoOffice Writer.pdf, but now just saves as filename - NeoOffice Writer.pdf. I'll check with a fresh set of prefs to see if it changes anything though.

Update : Sorry, it turned out to be the preferences.

fabriziovenerandi · Keymaker Joined: Oct 12, 2004 Posts: 77 Location: italia

I intalled test-6 and it seems to me that there is more redraw process using base module, for example clicking on form or table's name, all the list is refreshed or moving arrow over activity window the list is refreshed.
I'm not SURE there is more refreshing, but I feel this as strange, so I hope my mind is telling me that before neo was refreshing less.

f.

OPENSTEP · Posted: Tue Dec 19, 2006 10:07 am Post subject:

Note also that the form redrawing behaviour was first changed with Patch-10 to do more invalidation to workaround problems with "cheap whore" effects, stale focus rectangles, etc. You may be seeing side-effects from that recent change that may not be directly related to the test patch? But yes...they do redraw more often since it's the only "dumb" way to correct the behaviour of forms which aren't really designed to use native widgets Sad

ed

pluby · The Architect Joined: Jun 16, 2003 Posts: 11949

FYI. I think that I have fixed the hanging and printing bugs in test patch 6 (excessive flicker and some drawing errors and slow transitions in presentations) and I have posted a new test patch in bug 2034.

Maybe this latest test patch is ready to be put in an official patch?

Patrick