| View previous topic :: View next topic |
| Author |
Message |
ovvldc
Captain Naiobi
Joined: Sep 13, 2004
Posts: 2352
Location: Zürich, CH
|
 Posted: Wed Dec 16, 2009 2:29 am Post subject: New highlighting |
|
I was working with the 3.0.2EAP release candidate build and found that the new highlighting sometimes seems to colour more area than I expected.
Specifically, if I am using subscripted text in Impress, and do selections, the highlighted area seems to cover the area that would be the text size if all of selected bit was full-size text, instead of being made smaller by the subscripting.
Let me know if this is not clear, or when you cannot reproduce this.
_________________
"What do you think of Western Civilization?"
"I think it would be a good idea!"
- Mohandas Karamchand Gandhi |
|
| Back to top |
|
 |
ovvldc
Captain Naiobi
Joined: Sep 13, 2004
Posts: 2352
Location: Zürich, CH
|
| Posted: Wed Dec 16, 2009 2:36 am Post subject: |
|
Actually, this does not happens always. But I also see some residual highlighting that is not cleaned up after I deselect text in my slide. I will attach the presentation later.
_________________
"What do you think of Western Civilization?"
"I think it would be a good idea!"
- Mohandas Karamchand Gandhi |
|
| Back to top |
|
|
ovvldc
Captain Naiobi
Joined: Sep 13, 2004
Posts: 2352
Location: Zürich, CH
|
| Posted: Wed Dec 16, 2009 3:08 am Post subject: |
|
Here's the presentation I was working on while experiencing highlighting issues. Specifically, I was working on the bottom section of slide 12.
Good luck,
Oscar
_________________
"What do you think of Western Civilization?"
"I think it would be a good idea!"
- Mohandas Karamchand Gandhi |
|
| Back to top |
|
|
pluby
The Architect
Joined: Jun 16, 2003
Posts: 11949
|
| Posted: Wed Dec 16, 2009 9:41 am Post subject: Re: New highlighting |
|
| ovvldc wrote: | | Specifically, if I am using subscripted text in Impress, and do selections, the highlighted area seems to cover the area that would be the text size if all of selected bit was full-size text, instead of being made smaller by the subscripting. |
Thank you for the sample file. I think that I can reproduce this but to be sure, are you seeing the same as in the attached image when you start selecting in any line with a bullet and select into the right column?
If so, you are highlighting the entire table and this occurs in OpenOffice.org 3.0.1 as well. In Impress tables, when your are selecting text and you extend the selection outside of a single cell, the entire table gets selected.
While what is getting selected is normal, how the selection is painted is not. I need to find where the OpenOffice.org code is drawing its faded highlighting and replace it with our new highlighting logic.
I will post an update when I have this fixed.
Patrick
Last edited by pluby on Wed Dec 16, 2009 10:10 am; edited 1 time in total |
|
| Back to top |
|
|
narf
The Anomaly
Joined: Jan 21, 2007
Posts: 1075
|
| Posted: Wed Dec 16, 2009 9:51 am Post subject: |
|
I have opened bug bug 3575 to track this issue.
-- fran |
|
| Back to top |
|
|
ovvldc
Captain Naiobi
Joined: Sep 13, 2004
Posts: 2352
Location: Zürich, CH
|
| Posted: Wed Dec 16, 2009 9:52 am Post subject: |
|
What attached image? When I was working, I did notice the colours were different, but didn't think anything of it at the time.
Good luck in tracking the OOo code,
Oscar
_________________
"What do you think of Western Civilization?"
"I think it would be a good idea!"
- Mohandas Karamchand Gandhi |
|
| Back to top |
|
|
pluby
The Architect
Joined: Jun 16, 2003
Posts: 11949
|
| Posted: Wed Dec 16, 2009 10:11 am Post subject: |
|
| ovvldc wrote: | | What attached image? When I was working, I did notice the colours were different, but didn't think anything of it at the time. |
Oops. I failed to attach the screen snapshot. I have edited my post and added the image.
Patrick |
|
| Back to top |
|
|
pluby
The Architect
Joined: Jun 16, 2003
Posts: 11949
|
| Posted: Wed Dec 16, 2009 4:54 pm Post subject: Re: New highlighting |
|
| pluby wrote: | | If so, you are highlighting the entire table and this occurs in OpenOffice.org 3.0.1 as well. In Impress tables, when your are selecting text and you extend the selection outside of a single cell, the entire table gets selected. |
FYI. I was wrong about this occurring in OpenOffice.org 3.0.1. I must have accidently launched my NeoOffice 3.0.2 Early Access test build as I cannot reproduce this in OpenOffice.org 3.0.1. In other words, the entire table should not be highlighted in Impress like you are seeing.
Patrick |
|
| Back to top |
|
|
pluby
The Architect
Joined: Jun 16, 2003
Posts: 11949
|
| Posted: Wed Dec 16, 2009 5:07 pm Post subject: Re: New highlighting |
|
| pluby wrote: | | FYI. I was wrong about this occurring in OpenOffice.org 3.0.1. I must have accidently launched my NeoOffice 3.0.2 Early Access test build as I cannot reproduce this in OpenOffice.org 3.0.1. In other words, the entire table should not be highlighted in Impress like you are seeing. |
I am wrong again and I now know how to reproduce this in OpenOffice.org 3.0.1. The trick is that you have to start selecting in a table and then drag the mouse outside of the table before the "full table selection" occurs.
In the case of slide 12 in your sample document, you have two tables and each table has only a single cell with three bullet items. This is why the "full table selection" behavior may seem strange: you have the table borders set to white so you cannot see where your mouse goes outside of the table.
I still need to fix the highlighting color, but at least we now understand why large rectangles are getting selected.
Patrick |
|
| Back to top |
|
|
ovvldc
Captain Naiobi
Joined: Sep 13, 2004
Posts: 2352
Location: Zürich, CH
|
| Posted: Thu Dec 17, 2009 4:57 am Post subject: Re: New highlighting |
|
| pluby wrote: |
In the case of slide 12 in your sample document, you have two tables and each table has only a single cell with three bullet items. This is why the "full table selection" behavior may seem strange: you have the table borders set to white so you cannot see where your mouse goes outside of the table. |
Actually, in Impress I should have a 2x2 table on slide 12. So basically, it selected everything because I strayed with my mouse while selecting.
I hope you can find what is causing the faded highlight colour and highlighting residues to appear.
Best wishes,
Oscar
_________________
"What do you think of Western Civilization?"
"I think it would be a good idea!"
- Mohandas Karamchand Gandhi |
|
| Back to top |
|
|
pluby
The Architect
Joined: Jun 16, 2003
Posts: 11949
|
| Posted: Thu Dec 17, 2009 10:03 am Post subject: Re: New highlighting |
|
| ovvldc wrote: | | Actually, in Impress I should have a 2x2 table on slide 12. So basically, it selected everything because I strayed with my mouse while selecting. |
I stand corrected. I got confused about the table size by what I saw in the table properties dialog when I was trying to change the border color.
I can confirm that I see 4 cells and moving the mouse out of a cell will trigger selection of an entire cell and the selection behavior will continue to be in "select entire cell or nothing in a cell".
| ovvldc wrote: | | I hope you can find what is causing the faded highlight colour and highlighting residues to appear. |
So far I have not run into any problems. I have found the code that draws the faded highlighting and I am slowly splicing in the logic that is similar to what I used for the Calc highlighting.
I am hoping to have the initial solution running by tomorrow.
Patrick |
|
| Back to top |
|
|
ovvldc
Captain Naiobi
Joined: Sep 13, 2004
Posts: 2352
Location: Zürich, CH
|
| Posted: Thu Dec 17, 2009 10:35 am Post subject: |
|
Sounds good 
_________________
"What do you think of Western Civilization?"
"I think it would be a good idea!"
- Mohandas Karamchand Gandhi |
|
| Back to top |
|
|
pluby
The Architect
Joined: Jun 16, 2003
Posts: 11949
|
| Posted: Sat Dec 19, 2009 4:05 pm Post subject: |
|
FYI. I have fixed this bug in today's NeoOffice 3.0.2 Early Access test build. Can you install today's test build and tell us if the highlighting in Impress tables looks the same as it does elsewhere? In other words, have I eliminated the OpenOffice.org faded highlighting?
Patrick |
|
| Back to top |
|
|
ovvldc
Captain Naiobi
Joined: Sep 13, 2004
Posts: 2352
Location: Zürich, CH
|
| Posted: Sun Dec 20, 2009 7:17 am Post subject: |
|
Looks fine, and the residues are gone as well.
Best wishes and well done,
Oscar
_________________
"What do you think of Western Civilization?"
"I think it would be a good idea!"
- Mohandas Karamchand Gandhi |
|
| Back to top |
|
|
pluby
The Architect
Joined: Jun 16, 2003
Posts: 11949
|
|
| Back to top |
|
|
|
