Welcome to NeoOffice developer notes and announcements
NeoOffice
Developer notes and announcements
 
 

Problems after upgrading to Sierra or High Sierra? Try these steps
Problems after upgrading to NeoOffice 2017? Try these steps
Download or installation problems? Try these steps


Support
· NeoOffice Support
· NeoWiki


Announcements
· Twitter @NeoOffice


Downloads
· Download NeoOffice


RSS Feeds
· Announcements Only
· All Posts


  
NeoOffice :: View topic - Another Calc selection bug
Another Calc selection bug
 
Post new topic   Reply to topic    NeoOffice Forum Index -> NeoOffice Releases
View previous topic :: View next topic  
Author Message
amayze
The Merovingian


Joined: Oct 24, 2005
Posts: 561
Location: Edinburgh, Scotland

PostPosted: Sun Jan 11, 2015 3:20 pm    Post subject: Another Calc selection bug Reply with quote

I think I've found another Calc selection bug.

Steps to reproduce:

1. Open a new Calc Spreadsheet
2. Click on a cell down a bit from the top, say C11
3. Enter some text
4. Press Return then the Up arrow to return to C11
5. Type Cmd-C
6. Press the Down arrow
7. Type Cmd-V
8. Now press Shift and Right arrow
9. Observe that instead of cells C12 and D12 being highlighted, instead the range B1:C12 is highlighted.

This occurs with NeoOffice 3.4.1 test 10 patch 3 and NeoOffice 2014.5 on OS X 10.10.1

Whilst not a major issue, it is quite annoying!

Andy
Back to top
View user's profile Send private message Visit poster's website
amayze
The Merovingian


Joined: Oct 24, 2005
Posts: 561
Location: Edinburgh, Scotland

PostPosted: Sun Jan 11, 2015 3:41 pm    Post subject: Reply with quote

Sorry Patrick. I've just checked with LibreOffice 4.3.5.2 and the same thing happens, so it's not a NeoOffice bug per-se.

Andy
Back to top
View user's profile Send private message Visit poster's website
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11806
Location: California, USA

PostPosted: Sun Jan 11, 2015 5:47 pm    Post subject: Reply with quote

This behavior does not occur in either OpenOffice 3.3 or 4.1.1 so I suspect that this is a bug in that in the Go-oo code.

Over the years we have removed several Go-oo Calc bugs so I will look through the Go-oo 3.1.1.1 changes to the OpenOffice code that we have in NeoOffice and see if I can identify which Go-oo changes are causing this behavior.

Patrick
Back to top
View user's profile Send private message Visit poster's website
amayze
The Merovingian


Joined: Oct 24, 2005
Posts: 561
Location: Edinburgh, Scotland

PostPosted: Mon Jan 12, 2015 3:00 am    Post subject: Reply with quote

I've found another oddity.

1. Open a new spreadsheet
2. Select two cells in adjacent columns, i.e. C4 & D4.
3. Click the merge cells button in the toolbar.
4. With the arrow keys move the selection away from and back on to the merged cells.
5. Hold down Shift and press right arrow.
6. Observe that the selection does not grow to the right.

Other directions work fine, and sometimes the selection will grow to the right, but mostly it won't.

Again, this doesn't happen in LibreOffice 4.3.5.2, although it does have other bugs related to merged cells, which aren't present in NO.

Andy
Back to top
View user's profile Send private message Visit poster's website
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11806
Location: California, USA

PostPosted: Mon Jan 12, 2015 10:21 am    Post subject: Reply with quote

I can also reproduce this behavior. While fixing the Go-oo bug that you first reported in this topic, I saw some Go-oo code that handles merged cell selection so I will investigate and post when I have a fix for this second Go-oo bug.

Patrick
Back to top
View user's profile Send private message Visit poster's website
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11806
Location: California, USA

PostPosted: Tue Jan 13, 2015 8:03 pm    Post subject: Reply with quote

I think that I have fixed both of the Go-oo cell selection bugs.

Can you install one of the following test patches and tell us if the bugs are fixed for you?:

NeoOffice 2014.6:
http://nick.neooffice.org/test/NeoOffice-2014.6-Test-4-Intel.dmg

NeoOffice 2014.6 Free Edition:
http://nick.neooffice.org/test/NeoOffice-2014.6_Free_Edition-Test-4-Intel.dmg

NeoOffice 3.4.1:
http://nick.neooffice.org/test/NeoOffice-3.4.1-Patch-10-Test-4-Intel.dmg

Patrick
Back to top
View user's profile Send private message Visit poster's website
amayze
The Merovingian


Joined: Oct 24, 2005
Posts: 561
Location: Edinburgh, Scotland

PostPosted: Wed Jan 14, 2015 4:55 am    Post subject: Reply with quote

Nearly!

The original problems are fixed, but there are still a couple of issues.

First:
1. Select a merged cell
2. Press Shift-Up. The cells above are now highlighted.
3. Press Shift-Up again. No more cells are highlighted.

Second.
1. Select a merged cell made up of 2 cells on the same row.
2. Press Shift-Down a couple times.
3. Press Shift-Left several times.
4. Observe that it takes 3 key press to expand the selection to the left.

and similarly.
1. Repeat the above steps but with a merged cell made up of cells in 3 or more columns.
2. Observe that the selection will not expand to the left at all.

Third.
The number of Shift-arrow presses need to move the selection through adjacent merged cell is inconsistent.
1. Create to merged cells next to each other on the same row.
2. Highlight the rightmost one
3. Use Shift-Left arrow and Shift-Right arrow to grow the selection left and right through the merged cells.
4. Observe that it takes only one key press to grow or shrink the selection through the leftmost merged cell.
5. Highlight the leftmost merged cell.
6. Repeat step 3, but note that it takes an extra Shift-left arrow to shrink the selection through the right most merged cell.

The same issues occur with merged cells in the same column with the following changes in direction:
In the first case the selection will not grow past the first column to the left.
In the second case the selection will not grow up after being grown to the right.
In the third case the extra key press is required when shrink the selection back up through the lower merged cell having first selected the upper one and grown it down.

I hope that's clear! It's a lot of keypresses!

Thanks,

Andy
Back to top
View user's profile Send private message Visit poster's website
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11806
Location: California, USA

PostPosted: Wed Jan 14, 2015 9:44 am    Post subject: Reply with quote

After posting the test patch, I also found some issues when expanding and then unexpanding the selected range upward or rightward through merged cells.

I am getting more familiar with how the OpenOffice and Go-oo code handle merged cells so I will try some different approaches to handling selection range changes and post a test patch when I have some code for you to try.

Patrick
Back to top
View user's profile Send private message Visit poster's website
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11806
Location: California, USA

PostPosted: Wed Jan 14, 2015 10:49 pm    Post subject: Reply with quote

I think that I have fixed all of the Go-oo cell selection bugs that you have found so far in this forum topic.

Can you install one of the following test patches and tell us if the bugs are fixed for you?:

NeoOffice 2014.6:
http://nick.neooffice.org/test/NeoOffice-2014.6-Test-5-Intel.dmg

NeoOffice 2014.6 Free Edition:
http://nick.neooffice.org/test/NeoOffice-2014.6_Free_Edition-Test-5-Intel.dmg

NeoOffice 3.4.1:
http://nick.neooffice.org/test/NeoOffice-3.4.1-Patch-10-Test-5-Intel.dmg

Patrick
Back to top
View user's profile Send private message Visit poster's website
amayze
The Merovingian


Joined: Oct 24, 2005
Posts: 561
Location: Edinburgh, Scotland

PostPosted: Sat Jan 17, 2015 3:11 pm    Post subject: Reply with quote

Hi Patrick,

Sorry for being slow to report back on this - I'm currently living in the twilight zone that is having a newborn in the house!

I've installed the test 5 patches and it fixes all the issues I'd raised.

There is just one more thing, but I'm not sure how much of an issue it is.

1. Select the cell to the left of a merged row of cells.
2. Either press Shift-up or Shift-down to select two cells.
3. Use Shift-right to expand the selection to the right.
4. Observe that the merged cell is highlighted straight away while the cells above/below or highlighted one at a time.
5. Now Use Shift-left to shrink the selection again.
6. Observe that the whole highlighted area jumps across the merged cell in one go.
7. Also compare this behaviour to what occurs if the original selection is both above and below the merged row.

(I think) either of these behaviours is acceptable, however it's a bit odd that it does one thing in one direction and the other going back.

I'll leave you to decide if this is an issue and if so what the right solution is. I need to sleep now!!

Andy
Back to top
View user's profile Send private message Visit poster's website
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11806
Location: California, USA

PostPosted: Sun Jan 18, 2015 9:45 am    Post subject: Reply with quote

Although the behavior that you see may seem a bit odd, I implemented that behavior to match the OpenOffice code's selection by mouse behavior.

What I found is that the OpenOffice selection by mouse code selects cells based which corner of the selected range is moving. For example, if you initially Shift-Down in your steps 1 through 6, when you then Shift-Right the bottom right corner becomes the moving corner and that corner moves to the next unmerged cell. The merged cell above it is then highlighted because the selected rectangle now includes the merged cell's "anchor cell" (the anchor cell is a merged cell's top left corner cell).

Given the above OpenOffice behavior, I think what you see is normal behavior. But if you find any cases where the selection by key behavior does not match the selection by mouse behavior, let me know and I will investigate.

Patrick
Back to top
View user's profile Send private message Visit poster's website
pluby
The Architect
The Architect


Joined: Jun 16, 2003
Posts: 11806
Location: California, USA

PostPosted: Sat Jan 31, 2015 10:13 am    Post subject: Reply with quote

FYI. I have included the fixes for the Calc selection bugs in NeoOffice 2014.7 which is available in Apple's Mac App Store.

I have also included the fix in NeoOffice 3.4.1 Patch 11 which can be downloaded from the NeoOffice patch download page.

Patrick
Back to top
View user's profile Send private message Visit poster's website
Display posts from previous:   
Post new topic   Reply to topic    NeoOffice Forum Index -> NeoOffice Releases All times are GMT - 7 Hours
Page 1 of 1

 
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Powered by phpBB © 2001, 2005 phpBB Group

All logos and trademarks in this site are property of their respective owner. The comments are property of their posters, all the rest © Planamesa Inc.
NeoOffice is a registered trademark of Planamesa Inc. and may not be used without permission.
PHP-Nuke Copyright © 2005 by Francisco Burzi. This is free software, and you may redistribute it under the GPL. PHP-Nuke comes with absolutely no warranty, for details, see the license.
Page Generation: 0.02 Seconds