| View previous topic :: View next topic |
| Author |
Message |
narf
The Anomaly
Joined: Jan 21, 2007
Posts: 1075
|
 Posted: Mon May 10, 2010 8:56 pm Post subject: Minor problem with native highlighting |
|
I noticed a native highlighting artifact was left behind when copying merged cells in Calc. If I copy and paste the same text several times in merged cells the highlighting remains in cells to the right section of the merged cells
Here are steps to reproduce, and a picture too:
1. Create 3 sets each of two or more merged cells. In this case A2/B2, A4/B4, A6/B6
2. Enter enough text in the first set of merged cells (A2/B2) so it takes up more than one cell.
3. Copy and paste that merged cell from the first set of merged cells to the second. (From A2/B2 to A4/B4)
4. Then paste again in the third set of merged cells. (A6/B6)
There will be an artifact of the highlighting left behind in the second set of merged cells.
This is easily cleared up by scrolling to another part of the screen and scrolling back, or by minimizing and then maximizing the spreadsheet.
Fran |
|
| Back to top |
|
 |
narf
The Anomaly
Joined: Jan 21, 2007
Posts: 1075
|
| Posted: Mon May 10, 2010 9:08 pm Post subject: |
|
I forgot to mention that I can reproduce this on both NeoOffice 3.1.1 and NeoOffice 3.0.2. I am running Mac OS X 10.4.11 on PowerPC.
Fran |
|
| Back to top |
|
|
narf
The Anomaly
Joined: Jan 21, 2007
Posts: 1075
|
| Posted: Mon May 10, 2010 9:23 pm Post subject: |
|
FYI: I have submitted bug 3602 to track this issue.
Fran |
|
| Back to top |
|
|
pluby
The Architect
Joined: Jun 16, 2003
Posts: 11949
|
| Posted: Tue May 11, 2010 8:23 am Post subject: |
|
It sounds like my native highlighting code is not redrawing the full area that the merged cells occupy so you are left with the drawing artifacts until you refresh the cell by scrolling it out of view and back in again.
I will take start investigating this bug as soon as I finish fixing this crashing Calc bug. But once I have fixed this bug, I will post a test patch for you to try.
Patrick |
|
| Back to top |
|
|
pluby
The Architect
Joined: Jun 16, 2003
Posts: 11949
|
|
| Back to top |
|
|
narf
The Anomaly
Joined: Jan 21, 2007
Posts: 1075
|
| Posted: Thu May 13, 2010 11:57 am Post subject: |
|
Thanks for the test patch.
I installed it and it fixed the problem. I no longer get a highlighting artifact after copying and pasting.
I did notice is that the highlighting only shows in the upper leftmost original cell of a merged cell. Is this expected behavior?
Fran |
|
| Back to top |
|
|
pluby
The Architect
Joined: Jun 16, 2003
Posts: 11949
|
| Posted: Thu May 13, 2010 12:12 pm Post subject: |
|
| narf wrote: | | I did notice is that the highlighting only shows in the upper leftmost original cell of a merged cell. Is this expected behavior? |
Yes, this is normal behavior. The bug that you found was caused by my code drawing the highlight color in the entire merged cell whereas NeoOffice's underlying OpenOffice.org code only expects that top left corner cell of the merged cell to be highlighted.
Personally, the OpenOffice.org behavior of highlighting only the top left cell of the merged cell looks odd, but that behavior appears to be pretty deeply embedded in the OpenOffice.org code so I made our native highlighting code conform to that behavior.
Patrick |
|
| Back to top |
|
|
pluby
The Architect
Joined: Jun 16, 2003
Posts: 11949
|
| Posted: Mon Jun 14, 2010 10:44 am Post subject: |
|
FYI. The fix for this bug is included in NeoOffice 3.1.1 Patch 1. You can download the patch from the NeoOffice patch download page.
The fix has also been included in NeoOffice 3.0.2 Patch 5 which can be downloaded from here.
Patrick |
|
| Back to top |
|
|
|
